From c993f00ed76b60cc83f47e2614651bcca0cdcdce Mon Sep 17 00:00:00 2001 From: Ahmad Ansori Palembani Date: Tue, 25 Jun 2024 11:34:05 +0700 Subject: [PATCH 1/3] fix(reader): Save combined page does nothing --- CHANGELOG.md | 39 +------------------ .../tachiyomi/ui/reader/ReaderViewModel.kt | 2 +- 2 files changed, 2 insertions(+), 39 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c0364e3c64..a4b74c2568 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,42 +7,5 @@ ## Other ?? Technical stuff, what happened behind the scene --> -## Additions -- Added option to change long tap browse and recents nav behaviour - - Added browse long tap behaviour to open global search (AshbornXS) - - Added recents long tap behaviour to open last read chapter (AshbornXS) -- Added option to backup sensitive settings (such as tracker login tokens) -- Added beta version of "Data and storage" settings (can be accessed by long tapping "Data and storage") - -## Changes -- Remove download location redirection from `Settings > Downloads` -- Moved cache related stuff from `Settings > Advanced` to `Settings > Data and storage` -- Improve webview (AshbornXS) - - Show url as subtitle - - Add option to clear cookies - - Allow zoom -- Handle urls on global search (AshbornXS) -- Improve download queue (AshbornXS) - - Download badge now show download queue count - - Add option to move series to bottom -- Only show "open repo url" button when repo url is not empty - ## Fixes -- Fix potential crashes for some custom Android rom -- Allow MultipartBody.Builder for extensions -- Refresh extension repo now actually refresh extension(s) trust status -- Custom manga info now relink properly upon migration -- Fixed extension repo list did not update when a repo is added via deep link -- Fixed download unread trying to download filtered (by scanlator) chapters -- Fixed extensions not retaining their repo url -- Fixed more NullPointerException crashes -- Fixed split layout caused non-split images to not load - -## Other -- Migrate some StorIO queries to SQLDelight, should improve stability -- Migrate from Timber to Kermit -- Update okhttp monorepo to v5.0.0-alpha.14 -- Refactor backup code - - Migrate backup flags to not use bitwise - - Split it to several smaller classes -- Update androidx.compose.material3:material3 to v1.3.0-beta02 +- Fixed saving combined pages not doing anything diff --git a/app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderViewModel.kt b/app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderViewModel.kt index 85b7a645ae..257d553f16 100644 --- a/app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderViewModel.kt +++ b/app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderViewModel.kt @@ -794,7 +794,7 @@ class ReaderViewModel( "${manga.title} - ${chapter.preferredChapterName(context, manga, preferences)}".take(225), ) + (if (downloadPreferences.downloadWithId().get()) " (${chapter.id})" else "") + " - ${page1.number}-${page2.number}.jpg" - val destFile = directory.findFile(filename)!! + val destFile = directory.createFile(filename)!! stream.use { input -> destFile.openOutputStream().use { output -> input.copyTo(output) From 0809841f837019fac896b06ee0d50d0d372d688d Mon Sep 17 00:00:00 2001 From: Ahmad Ansori Palembani Date: Tue, 25 Jun 2024 12:08:33 +0700 Subject: [PATCH 2/3] chore(release): v1.8.4.1 --- .github/ISSUE_TEMPLATE/feature_request.yml | 2 +- .github/ISSUE_TEMPLATE/issue_report.yml | 2 +- app/build.gradle.kts | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/feature_request.yml b/.github/ISSUE_TEMPLATE/feature_request.yml index 1f9c3dc2ed..87862fa4c5 100644 --- a/.github/ISSUE_TEMPLATE/feature_request.yml +++ b/.github/ISSUE_TEMPLATE/feature_request.yml @@ -35,7 +35,7 @@ body: required: true - label: If this is an issue with an extension, or a request for an extension, I should be contacting the extensions repository's maintainer/support for help. required: true - - label: I have updated the app to version **[1.8.4](https://github.com/null2264/yokai/releases/latest)**. + - label: I have updated the app to version **[1.8.4.1](https://github.com/null2264/yokai/releases/latest)**. required: true - label: I have checked through the app settings for my feature. required: true diff --git a/.github/ISSUE_TEMPLATE/issue_report.yml b/.github/ISSUE_TEMPLATE/issue_report.yml index b54d6d8112..c3ce7a72c0 100644 --- a/.github/ISSUE_TEMPLATE/issue_report.yml +++ b/.github/ISSUE_TEMPLATE/issue_report.yml @@ -100,7 +100,7 @@ body: required: true - label: I have tried the [troubleshooting guide](https://mihon.app/help/). required: true - - label: I have updated the app to version **[1.8.4](https://github.com/null2264/yokai/releases/latest)**. + - label: I have updated the app to version **[1.8.4.1](https://github.com/null2264/yokai/releases/latest)**. required: true - label: I have updated all installed extensions. required: true diff --git a/app/build.gradle.kts b/app/build.gradle.kts index 98911bdf55..ac2c8a3877 100644 --- a/app/build.gradle.kts +++ b/app/build.gradle.kts @@ -46,8 +46,8 @@ android { minSdk = AndroidConfig.minSdk targetSdk = AndroidConfig.targetSdk applicationId = "eu.kanade.tachiyomi" - versionCode = 136 - versionName = "1.8.4" + versionCode = 137 + versionName = "1.8.4.1" testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner" multiDexEnabled = true From 29231816cf5f8f577bef4fcdba5153e9468ae7e5 Mon Sep 17 00:00:00 2001 From: Ahmad Ansori Palembani Date: Mon, 1 Jul 2024 09:47:51 +0700 Subject: [PATCH 3/3] fix(style): Change "Open source repo" icon --- CHANGELOG.md | 4 ++-- app/build.gradle.kts | 4 ++-- app/src/main/res/drawable/ic_code_blocks_24dp.xml | 5 +++++ app/src/main/res/menu/extension_details.xml | 4 ++-- 4 files changed, 11 insertions(+), 6 deletions(-) create mode 100644 app/src/main/res/drawable/ic_code_blocks_24dp.xml diff --git a/CHANGELOG.md b/CHANGELOG.md index a4b74c2568..16d9e7dee4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,5 +7,5 @@ ## Other ?? Technical stuff, what happened behind the scene --> -## Fixes -- Fixed saving combined pages not doing anything +## Changes +- Changed "Open source repo" icon to prevent confusion diff --git a/app/build.gradle.kts b/app/build.gradle.kts index ac2c8a3877..4d3de17f15 100644 --- a/app/build.gradle.kts +++ b/app/build.gradle.kts @@ -46,8 +46,8 @@ android { minSdk = AndroidConfig.minSdk targetSdk = AndroidConfig.targetSdk applicationId = "eu.kanade.tachiyomi" - versionCode = 137 - versionName = "1.8.4.1" + versionCode = 138 + versionName = "1.8.4.2" testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner" multiDexEnabled = true diff --git a/app/src/main/res/drawable/ic_code_blocks_24dp.xml b/app/src/main/res/drawable/ic_code_blocks_24dp.xml new file mode 100644 index 0000000000..d699b8f58e --- /dev/null +++ b/app/src/main/res/drawable/ic_code_blocks_24dp.xml @@ -0,0 +1,5 @@ + + + + + diff --git a/app/src/main/res/menu/extension_details.xml b/app/src/main/res/menu/extension_details.xml index ffbc344196..77c039a27c 100644 --- a/app/src/main/res/menu/extension_details.xml +++ b/app/src/main/res/menu/extension_details.xml @@ -3,7 +3,7 @@ @@ -13,4 +13,4 @@ android:title="@string/clear_cookies" app:showAsAction="never" /> - \ No newline at end of file +