From f15fbdc8cbd233dfc4598d97dd8cc1c90bab827a Mon Sep 17 00:00:00 2001
From: Ahmad Ansori Palembani <palembani@gmail.com>
Date: Fri, 16 Aug 2024 07:06:22 +0700
Subject: [PATCH] fix(preference): Minus and Plus assign missing set(...) call

---
 CHANGELOG.md                                                  | 3 +++
 .../java/eu/kanade/tachiyomi/ui/library/LibraryPresenter.kt   | 2 +-
 .../kotlin/eu/kanade/tachiyomi/core/preference/Preference.kt  | 4 ++--
 3 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 079d846ffe..21f5c3ac53 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -9,6 +9,9 @@
 
 ## Other  ?? Technical stuff, what happened behind the scene
 -->
+## Fixes
+- Fixed some preference not being saved properly
+
 ## Other
 - Update dependency co.touchlab:kermit to v2.0.4
 - Update lifecycle to v2.8.4
diff --git a/app/src/main/java/eu/kanade/tachiyomi/ui/library/LibraryPresenter.kt b/app/src/main/java/eu/kanade/tachiyomi/ui/library/LibraryPresenter.kt
index 78d6edb9fe..b0c900b0e6 100644
--- a/app/src/main/java/eu/kanade/tachiyomi/ui/library/LibraryPresenter.kt
+++ b/app/src/main/java/eu/kanade/tachiyomi/ui/library/LibraryPresenter.kt
@@ -887,7 +887,7 @@ class LibraryPresenter(
         return items to hiddenItems
     }
 
-    private suspend fun getLibraryItems(
+    private fun getLibraryItems(
         allCategories: List<Category>,
         libraryManga: List<LibraryManga>,
         sortingMode: Int,
diff --git a/core/src/commonMain/kotlin/eu/kanade/tachiyomi/core/preference/Preference.kt b/core/src/commonMain/kotlin/eu/kanade/tachiyomi/core/preference/Preference.kt
index 2950d0db48..27806f6398 100644
--- a/core/src/commonMain/kotlin/eu/kanade/tachiyomi/core/preference/Preference.kt
+++ b/core/src/commonMain/kotlin/eu/kanade/tachiyomi/core/preference/Preference.kt
@@ -54,11 +54,11 @@ inline fun <reified T, R : T> Preference<T>.getAndSet(crossinline block: (T) ->
 )
 
 operator fun <T> Preference<Set<T>>.plusAssign(item: Collection<T>) {
-    get() + item
+    set(get() + item)
 }
 
 operator fun <T> Preference<Set<T>>.minusAssign(item: Collection<T>) {
-    get() - item
+    set(get() - item)
 }
 
 operator fun <T> Preference<Set<T>>.plusAssign(item: T) {