Add Compose lint checks

Still need to address most of them though.
This commit is contained in:
arkon 2023-11-11 18:13:44 -05:00
parent 402e2c47fb
commit cb67f1de52
22 changed files with 57 additions and 26 deletions

View file

@ -25,7 +25,8 @@ dependencies {
implementation(project(":domain"))
implementation(project(":presentation-core"))
implementation(androidx.glance)
implementation(compose.glance)
lintChecks(compose.lintchecks)
implementation(platform(libs.coil.bom))
implementation(libs.coil.core)

View file

@ -95,10 +95,10 @@ abstract class BaseUpdatesGridGlanceWidget(
val data by flow.collectAsState(initial = null)
UpdatesWidget(
data = data,
modifier = containerModifier,
contentColor = foreground,
topPadding = topPadding,
bottomPadding = bottomPadding,
modifier = containerModifier,
)
}
}

View file

@ -17,7 +17,10 @@ val CoverWidth = 58.dp
val CoverHeight = 87.dp
@Composable
fun UpdatesMangaCover(modifier: GlanceModifier = GlanceModifier, cover: Bitmap?) {
fun UpdatesMangaCover(
cover: Bitmap?,
modifier: GlanceModifier = GlanceModifier,
) {
Box(
modifier = modifier
.size(width = CoverWidth, height = CoverHeight)

View file

@ -29,10 +29,10 @@ import tachiyomi.presentation.widget.util.stringResource
@Composable
fun UpdatesWidget(
data: List<Pair<Long, Bitmap?>>?,
modifier: GlanceModifier = GlanceModifier,
contentColor: ColorProvider,
topPadding: Dp,
bottomPadding: Dp,
modifier: GlanceModifier = GlanceModifier,
) {
Box(
contentAlignment = Alignment.Center,
@ -83,8 +83,8 @@ fun UpdatesWidget(
addCategory(mangaId.toString())
}
UpdatesMangaCover(
modifier = GlanceModifier.clickable(actionStartActivity(intent)),
cover = cover,
modifier = GlanceModifier.clickable(actionStartActivity(intent)),
)
}
}