From afa4c20cb609a07fdfa10d5c4390dff0436db2db Mon Sep 17 00:00:00 2001 From: Jays2Kings Date: Wed, 18 Oct 2023 18:49:02 -0700 Subject: [PATCH] provide unique id names to the frame layouts since it was causing a crash with the views staying in memory --- .../java/eu/kanade/tachiyomi/ui/recents/RecentsController.kt | 4 ++-- app/src/main/res/layout/browse_controller.xml | 5 ++--- app/src/main/res/layout/manga_details_controller.xml | 2 +- app/src/main/res/layout/recents_controller.xml | 2 +- app/src/main/res/layout/sub_debug_controller.xml | 2 +- 5 files changed, 7 insertions(+), 8 deletions(-) diff --git a/app/src/main/java/eu/kanade/tachiyomi/ui/recents/RecentsController.kt b/app/src/main/java/eu/kanade/tachiyomi/ui/recents/RecentsController.kt index 6d4f9d73ef..c7a6663087 100644 --- a/app/src/main/java/eu/kanade/tachiyomi/ui/recents/RecentsController.kt +++ b/app/src/main/java/eu/kanade/tachiyomi/ui/recents/RecentsController.kt @@ -260,7 +260,7 @@ class RecentsController(bundle: Bundle? = null) : if (presenter.recentItems.isNotEmpty()) { adapter.updateDataSet(presenter.recentItems) } else { - binding.frameLayout.alpha = 0f + binding.recentsFrameLayout.alpha = 0f } binding.downloadBottomSheet.dlBottomSheet.onCreate(this) @@ -573,7 +573,7 @@ class RecentsController(bundle: Bundle? = null) : (activity as? MainActivity)?.showNotificationPermissionPrompt() } binding.progress.isVisible = false - binding.frameLayout.alpha = 1f + binding.recentsFrameLayout.alpha = 1f binding.swipeRefresh.isRefreshing = LibraryUpdateJob.isRunning(view!!.context) adapter.removeAllScrollableHeaders() adapter.updateDataSet(recents) diff --git a/app/src/main/res/layout/browse_controller.xml b/app/src/main/res/layout/browse_controller.xml index 5b4968501f..318d8e23ec 100644 --- a/app/src/main/res/layout/browse_controller.xml +++ b/app/src/main/res/layout/browse_controller.xml @@ -3,11 +3,10 @@ xmlns:tools="http://schemas.android.com/tools" android:layout_width="match_parent" android:layout_height="match_parent" - android:id="@+id/browse_layout" - xmlns:app="http://schemas.android.com/apk/res-auto"> + android:id="@+id/browse_layout"> diff --git a/app/src/main/res/layout/manga_details_controller.xml b/app/src/main/res/layout/manga_details_controller.xml index f7ea837b8c..2cc741941d 100644 --- a/app/src/main/res/layout/manga_details_controller.xml +++ b/app/src/main/res/layout/manga_details_controller.xml @@ -2,7 +2,7 @@ diff --git a/app/src/main/res/layout/recents_controller.xml b/app/src/main/res/layout/recents_controller.xml index e2ac6fc441..3770d3da6b 100644 --- a/app/src/main/res/layout/recents_controller.xml +++ b/app/src/main/res/layout/recents_controller.xml @@ -18,7 +18,7 @@ android:layout_height="match_parent"> diff --git a/app/src/main/res/layout/sub_debug_controller.xml b/app/src/main/res/layout/sub_debug_controller.xml index 994004d4bf..70f103e18c 100644 --- a/app/src/main/res/layout/sub_debug_controller.xml +++ b/app/src/main/res/layout/sub_debug_controller.xml @@ -1,6 +1,6 @@