From a3672be7282c553017d35b310fb5a148d677ff14 Mon Sep 17 00:00:00 2001 From: Ahmad Ansori Palembani Date: Fri, 3 Jan 2025 10:44:38 +0700 Subject: [PATCH] fix(myanimelist): Fix nullability and fallback to medium cover if large cover is null --- .../tachiyomi/data/track/myanimelist/MyAnimeListApi.kt | 2 +- .../kanade/tachiyomi/data/track/myanimelist/dto/MALManga.kt | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/app/src/main/java/eu/kanade/tachiyomi/data/track/myanimelist/MyAnimeListApi.kt b/app/src/main/java/eu/kanade/tachiyomi/data/track/myanimelist/MyAnimeListApi.kt index 9468ee359e..b3411cd2d7 100644 --- a/app/src/main/java/eu/kanade/tachiyomi/data/track/myanimelist/MyAnimeListApi.kt +++ b/app/src/main/java/eu/kanade/tachiyomi/data/track/myanimelist/MyAnimeListApi.kt @@ -96,7 +96,7 @@ class MyAnimeListApi(private val client: OkHttpClient, interceptor: MyAnimeListI title = it.title summary = it.synopsis total_chapters = it.numChapters - cover_url = it.covers.large + cover_url = (it.covers?.large ?: it.covers?.medium).orEmpty() tracking_url = "https://myanimelist.net/manga/$media_id" publishing_status = it.status.replace("_", " ") publishing_type = it.mediaType.replace("_", " ") diff --git a/app/src/main/java/eu/kanade/tachiyomi/data/track/myanimelist/dto/MALManga.kt b/app/src/main/java/eu/kanade/tachiyomi/data/track/myanimelist/dto/MALManga.kt index c4ab92ee92..6950c54960 100644 --- a/app/src/main/java/eu/kanade/tachiyomi/data/track/myanimelist/dto/MALManga.kt +++ b/app/src/main/java/eu/kanade/tachiyomi/data/track/myanimelist/dto/MALManga.kt @@ -12,7 +12,7 @@ data class MALManga( val numChapters: Long, val mean: Double = -1.0, @SerialName("main_picture") - val covers: MALMangaCovers, + val covers: MALMangaCovers?, val status: String, @SerialName("media_type") val mediaType: String, @@ -22,5 +22,6 @@ data class MALManga( @Serializable data class MALMangaCovers( - val large: String = "", + val large: String?, + val medium: String, )