From 758816428c5e8011213ebac20a7c85a6d5fc0e6a Mon Sep 17 00:00:00 2001 From: Jays2Kings Date: Thu, 14 Apr 2022 14:24:47 -0500 Subject: [PATCH] clean upmarginTop and marginBottom from view extensions --- .../java/eu/kanade/tachiyomi/ui/base/MaterialFastScroll.kt | 2 +- .../tachiyomi/ui/library/category/CategoryRecyclerView.kt | 2 +- .../ui/migration/manga/design/PreMigrationController.kt | 2 +- .../eu/kanade/tachiyomi/ui/webview/BaseWebViewActivity.kt | 2 +- .../java/eu/kanade/tachiyomi/util/view/ViewExtensions.kt | 7 +------ 5 files changed, 5 insertions(+), 10 deletions(-) diff --git a/app/src/main/java/eu/kanade/tachiyomi/ui/base/MaterialFastScroll.kt b/app/src/main/java/eu/kanade/tachiyomi/ui/base/MaterialFastScroll.kt index 7095a6cd01..62d6f93c32 100644 --- a/app/src/main/java/eu/kanade/tachiyomi/ui/base/MaterialFastScroll.kt +++ b/app/src/main/java/eu/kanade/tachiyomi/ui/base/MaterialFastScroll.kt @@ -4,6 +4,7 @@ import android.content.Context import android.util.AttributeSet import android.view.MotionEvent import androidx.core.view.ViewCompat +import androidx.core.view.marginTop import androidx.recyclerview.widget.LinearLayoutManager import androidx.recyclerview.widget.RecyclerView import androidx.recyclerview.widget.StaggeredGridLayoutManager @@ -12,7 +13,6 @@ import eu.kanade.tachiyomi.R import eu.kanade.tachiyomi.util.system.dpToPx import eu.kanade.tachiyomi.util.system.dpToPxEnd import eu.kanade.tachiyomi.util.system.isLTR -import eu.kanade.tachiyomi.util.view.marginTop import kotlin.math.abs class MaterialFastScroll @JvmOverloads constructor(context: Context, attrs: AttributeSet? = null) : diff --git a/app/src/main/java/eu/kanade/tachiyomi/ui/library/category/CategoryRecyclerView.kt b/app/src/main/java/eu/kanade/tachiyomi/ui/library/category/CategoryRecyclerView.kt index 08c61668f8..d562571650 100644 --- a/app/src/main/java/eu/kanade/tachiyomi/ui/library/category/CategoryRecyclerView.kt +++ b/app/src/main/java/eu/kanade/tachiyomi/ui/library/category/CategoryRecyclerView.kt @@ -3,6 +3,7 @@ package eu.kanade.tachiyomi.ui.library.category import android.content.Context import android.util.AttributeSet import android.view.ViewGroup +import androidx.core.view.marginTop import androidx.recyclerview.widget.LinearLayoutManager import androidx.recyclerview.widget.RecyclerView import com.mikepenz.fastadapter.FastAdapter @@ -10,7 +11,6 @@ import com.mikepenz.fastadapter.adapters.ItemAdapter import com.mikepenz.fastadapter.listeners.OnBindViewHolderListenerImpl import eu.kanade.tachiyomi.data.database.models.Category import eu.kanade.tachiyomi.util.system.dpToPx -import eu.kanade.tachiyomi.util.view.marginTop class CategoryRecyclerView @JvmOverloads constructor( context: Context, diff --git a/app/src/main/java/eu/kanade/tachiyomi/ui/migration/manga/design/PreMigrationController.kt b/app/src/main/java/eu/kanade/tachiyomi/ui/migration/manga/design/PreMigrationController.kt index fbd757ce9d..7ec868e9a3 100644 --- a/app/src/main/java/eu/kanade/tachiyomi/ui/migration/manga/design/PreMigrationController.kt +++ b/app/src/main/java/eu/kanade/tachiyomi/ui/migration/manga/design/PreMigrationController.kt @@ -9,6 +9,7 @@ import android.view.View import android.view.ViewGroup import android.widget.FrameLayout import androidx.core.view.WindowInsetsCompat.Type.systemBars +import androidx.core.view.marginBottom import androidx.core.view.updateLayoutParams import androidx.core.view.updatePaddingRelative import androidx.recyclerview.widget.LinearLayoutManager @@ -27,7 +28,6 @@ import eu.kanade.tachiyomi.ui.migration.manga.process.MigrationProcedureConfig import eu.kanade.tachiyomi.util.view.doOnApplyWindowInsetsCompat import eu.kanade.tachiyomi.util.view.expand import eu.kanade.tachiyomi.util.view.liftAppbarWith -import eu.kanade.tachiyomi.util.view.marginBottom import eu.kanade.tachiyomi.util.view.withFadeTransaction import uy.kohesive.injekt.injectLazy diff --git a/app/src/main/java/eu/kanade/tachiyomi/ui/webview/BaseWebViewActivity.kt b/app/src/main/java/eu/kanade/tachiyomi/ui/webview/BaseWebViewActivity.kt index 2404db473e..6e1ddd076e 100644 --- a/app/src/main/java/eu/kanade/tachiyomi/ui/webview/BaseWebViewActivity.kt +++ b/app/src/main/java/eu/kanade/tachiyomi/ui/webview/BaseWebViewActivity.kt @@ -22,6 +22,7 @@ import androidx.core.view.WindowInsetsCompat.Type.systemBars import androidx.core.view.WindowInsetsControllerCompat import androidx.core.view.isInvisible import androidx.core.view.isVisible +import androidx.core.view.marginBottom import androidx.core.view.updateLayoutParams import androidx.core.view.updatePadding import androidx.webkit.WebSettingsCompat.DARK_STRATEGY_WEB_THEME_DARKENING_ONLY @@ -38,7 +39,6 @@ import eu.kanade.tachiyomi.util.system.getPrefTheme import eu.kanade.tachiyomi.util.system.getResourceColor import eu.kanade.tachiyomi.util.system.isInNightMode import eu.kanade.tachiyomi.util.system.setDefaultSettings -import eu.kanade.tachiyomi.util.view.marginBottom import eu.kanade.tachiyomi.util.view.setStyle open class BaseWebViewActivity : BaseActivity() { diff --git a/app/src/main/java/eu/kanade/tachiyomi/util/view/ViewExtensions.kt b/app/src/main/java/eu/kanade/tachiyomi/util/view/ViewExtensions.kt index 738c7cee29..0cb2107777 100644 --- a/app/src/main/java/eu/kanade/tachiyomi/util/view/ViewExtensions.kt +++ b/app/src/main/java/eu/kanade/tachiyomi/util/view/ViewExtensions.kt @@ -46,6 +46,7 @@ import androidx.core.view.WindowInsetsCompat.Type.ime import androidx.core.view.WindowInsetsCompat.Type.systemBars import androidx.core.view.descendants import androidx.core.view.forEach +import androidx.core.view.marginBottom import androidx.core.view.updateLayoutParams import androidx.core.view.updatePaddingRelative import androidx.interpolator.view.animation.FastOutLinearInInterpolator @@ -126,12 +127,6 @@ fun Snackbar.getText(): CharSequence { return textView.text } -inline val View.marginTop: Int - get() = (layoutParams as? ViewGroup.MarginLayoutParams)?.topMargin ?: 0 - -inline val View.marginBottom: Int - get() = (layoutParams as? ViewGroup.MarginLayoutParams)?.bottomMargin ?: 0 - object RecyclerWindowInsetsListener : View.OnApplyWindowInsetsListener { override fun onApplyWindowInsets(v: View, insets: WindowInsets): WindowInsets { v.updatePaddingRelative(